Add support for Ancestral Empowerment, Ancestral Call, Crescendo II and III, Infernal Cry, and "Ancestrally Boosted Attacks" passive nodes#1839
Merged
LocalIdentity merged 21 commits intoMay 28, 2026
Conversation
Peechey
changed the title
Peechey
changed the title
one commit so I can revert if it goes boom
update CalcSection from "Exerted Warcries" to "Ancestral Boosts"
…Empowerment with Fist of War fix Fist of War/ancestrally boosted slams more AOE to inc AOE add test for Combined logic for Ancestral Empowerment and Fist of War
Peechey
force-pushed
the
feature/ancestral-boost-support
branch
from
e94ad65 to
dcf5942
Compare
Peechey
changed the title
Peechey
force-pushed
the
feature/ancestral-boost-support
branch
from
927fb58 to
04f89c8
Compare
fix Ancestral Empowerment not getting the double from fist of war III
also refactored Crescendo III to use the new logic instead of an extra isolated block of logic by introducing a way to conditionally max uptime for Boosted or Empowered attacks
Contributor
Author
|
Updated for PR comments but one issue that I haven't fully solved is uptime scaling every mod that requires Condition:Empowered. I've updated to account for Damage mods with this condition but there are a couple others like DamageGainAs and I'm not sure if there's a better way to address all of those other than adding each mod into the scaling logic. Possibly some multiplier or percentstat but then we may lose breakdowns and clarity. Additionally, the latest commit refactors Crescendo III/Final Strike Boosted into the rest of the code so there is not extra logic. Hopefully that Max...Ratio flag can be used going forward for any other 100% uptime Boosted/Empowered needs. |
added 3 commits
May 29, 2026 00:22
Move the Infernal Cry buff to calc offence so it doesn't rely on stale calc output Fix Ancestral Empowerment uptime calculation Move gain table so Infernal Cry still works
jay9297
added a commit
to jay9297/PathOfBuilding-PoE2
that referenced
this pull request
May 29, 2026
* Chore: Bump action version numbers (PathOfBuildingCommunity#1993) * Add support for Legacy Grand Spectrum mods (PathOfBuildingCommunity#1994) Some old mods don't require the socketed in text Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for Ancestral Empowerment, Ancestral Call, Crescendo II and III, Infernal Cry, and "Ancestrally Boosted Attacks" passive nodes (PathOfBuildingCommunity#1839) * add support for Ancestral Call, Crescendo II and III, ancestral boost tree nodes * fix ancestral call inc dmg from tree * big ole refactor so we stop duplicating code one commit so I can revert if it goes boom * added test update CalcSection from "Exerted Warcries" to "Ancestral Boosts" * add data map for gemName given a modSource * boosted attacks configOption * add support for Ancestral Empowerment, including combining Ancestral Empowerment with Fist of War fix Fist of War/ancestrally boosted slams more AOE to inc AOE add test for Combined logic for Ancestral Empowerment and Fist of War * comment spelling * better label * fix avg aoe from fist of war * forgot AOE portion for Crescendo III * add support for Infernal Cry's empowered buff * refactor away from specific baseMod for FistOfWar fix Ancestral Empowerment not getting the double from fist of war III * empowered condition for all Ancestrally Boosted * ancestralBoostEffect * multiplier instead * pr comments also refactored Crescendo III to use the new logic instead of an extra isolated block of logic by introducing a way to conditionally max uptime for Boosted or Empowered attacks * Fix issues Move the Infernal Cry buff to calc offence so it doesn't rely on stale calc output Fix Ancestral Empowerment uptime calculation Move gain table so Infernal Cry still works * Fix spelling --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for 0.5 JSON skill tree (PathOfBuildingCommunity#1984) * Passive tree parser from ggg web data * enhanced escapeGGGString * Fix ascendancy unlock constraint check in node search parameters * Refactor DrawQuadAndRotate to handle different data lengths for vertex calculations * Add node overlay for Blighted Notable Frames in passive tree * Fix typos and improve comments in passive tree script * Fix typos in ascendancy handling and update inner radius calculations in passive tree script * Refactor passive tree node replacement logic and add switchable options for Druid nodes * Add support for alias notable maps and enhance jewel socket handling - Enhanced passivetree_ggg.lua to support aliasNotableMap for jewel sockets. * Rename aliasNotableMap to aliasPassiveSocket for clarity in passive tree data * Enhance jewel socket handling by adding noRadius property and updating related logic in passive tree * Enable Abyssal Lich parser * Fix tests Export ModCache Fix crash with class Ids Fix unarmed data for Ids * Add legacy class ID remap Old builds from 0.1 to 0.3 used the wrong id for the character class and opening them now would convert them to the wrong class. This maps the old builds so they now open correctly * Formatting + typos * AliasPassiveSocket fix Was using the wrong name from a previous commit * Export fixes Uses the tree data folder to look for the ggg assets and json files Fixes the tree file changing each time on export due to pairs usage * Use copy file command to speed up export Now runs in 0.1s instead of 8s --------- Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Remove aliasPassiveSocket temp code * Fix Hollow Palm Technique parsing and add Spectral Ward support - Make 'rating' optional in evasion suffix patterns (r?a?t?i?n?g?) - Remove dead-code keystone pattern with wrong parameter order - Add bounds check for hollowPalmAddedPhys table (levels 1-40) - Add descriptive line patterns for Hollow Palm Technique node - Add Spectral Ward pattern for 'per X item evasion on equipped body armour' - Update ModCache entries for all affected patterns --------- Co-authored-by: Nighty <Nightblade@users.noreply.github.com> Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com> Co-authored-by: Juangui <80857657+justjuangui@users.noreply.github.com> Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: jay9297 <jay9297@users.noreply.github.com>
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…nd III, Infernal Cry, and "Ancestrally Boosted Attacks" passive nodes (PathOfBuildingCommunity#1839) * add support for Ancestral Call, Crescendo II and III, ancestral boost tree nodes * fix ancestral call inc dmg from tree * big ole refactor so we stop duplicating code one commit so I can revert if it goes boom * added test update CalcSection from "Exerted Warcries" to "Ancestral Boosts" * add data map for gemName given a modSource * boosted attacks configOption * add support for Ancestral Empowerment, including combining Ancestral Empowerment with Fist of War fix Fist of War/ancestrally boosted slams more AOE to inc AOE add test for Combined logic for Ancestral Empowerment and Fist of War * comment spelling * better label * fix avg aoe from fist of war * forgot AOE portion for Crescendo III * add support for Infernal Cry's empowered buff * refactor away from specific baseMod for FistOfWar fix Ancestral Empowerment not getting the double from fist of war III * empowered condition for all Ancestrally Boosted * ancestralBoostEffect * multiplier instead * pr comments also refactored Crescendo III to use the new logic instead of an extra isolated block of logic by introducing a way to conditionally max uptime for Boosted or Empowered attacks * Fix issues Move the Infernal Cry buff to calc offence so it doesn't rely on stale calc output Fix Ancestral Empowerment uptime calculation Move gain table so Infernal Cry still works * Fix spelling --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding support for Ancestral Call I and II, copying how we did Fist of War by refactoring into a dynamic function
Adding support for Crescendo II and III, attack speed for non Final Strike and Ancestrally Boosting Final Strike
Adding support for the southwest cluster of nodes in the Tree for increased Damage and AoE for Ancestrally Boosted Attacks
Update
Adding support for Ancestral Empowerment as well as combining this passive with Fist of War.
Fix the MORE AoE of ancestrally boosted slams to INC AoE https://www.poe2wiki.net/wiki/Ancestral_Boost
Show boosted attacks configOption for Max Hit Effect
Add test for the combined behavior
Update 2
Adding support for Infernal Cry's damage gain as fire buff
I updated the CalcSections too soooo look at this for up to date labeling because I aint grabbing all those pics again.
Update 3
A lot more has changed... moving away from the hardcoded mods in Fist of War and using Condition:AncestrallyBoosted to apply the mod. Using AncestralBoostEffect as a multiplier to scale the base Ancestral Boost stats. Most of these pictures are outdated.
infernal cry with 25 power override
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
leap slam
ancestral call
--
--
--